search

keep-starknet-strange / madara

DEPRECATED in favor of https://github.com/madara-alliance/madara
MIT License
531 stars 301 forks source link

dev: Make HasherT methods accept iterator #1621

Closed fishseabowl closed 1 month ago

fishseabowl commented 4 months ago

Pull Request type

Please add the labels corresponding to the type of changes your PR introduces:

What is the current behavior?

Resolves: #1613

What is the new behavior?

  1. HasherT methods accept iterator

  2. Add a default impl for compute_hash_on_wrappers

    -

Does this introduce a breaking change?

Other information

tdelabro commented 3 months ago

Okay, mb I didn't remember we were internally calling starknet-rs, which takes an &[FieldElement].

For now let's just keep the default impl part of the PR and revert the IntoIterator one. Once this is merged https://github.com/xJonathanLEI/starknet-rs/pull/594, we will add it

fishseabowl commented 3 months ago

Okay, mb I didn't remember we were internally calling starknet-rs, which takes an &[FieldElement].

For now let's just keep the default impl part of the PR and revert the IntoIterator one. Once this is merged xJonathanLEI/starknet-rs#594, we will add it

Sure. Thank you for your review.

github-actions[bot] commented 2 months ago

There hasn't been any activity on this pull request recently, and in order to prioritize active work, it has been marked as stale. This PR will be closed and locked in 7 days if no further activity occurs. Thank you for your contributions!

tdelabro commented 1 month ago

repository archived in favor of https://github.com/madara-alliance/madara