search

keep-starknet-strange / madara

DEPRECATED in favor of https://github.com/madara-alliance/madara
MIT License
531 stars 303 forks source link

Max steps #545

Closed 0xLucqs closed 1 year ago

0xLucqs commented 1 year ago

Description

Each transaction has a maximum number of steps it can consume. For now they are hardcoded but we need to configure them in the starknet pallet like this.

#[pallet::config]
    pub trait Config: frame_system::Config {
        ...
        type InvokeTxMaxNSteps: Get<u32>;
        type ValidateMaxNSteps: Get<u32>;
    }

Those values need to be fed in the block context which is created by the function get_block_context

Acceptance criteria

DaVinciDz commented 1 year ago

Hey @LucasLvy , i would like to work on this one :)

0xLucqs commented 1 year ago

Any news on that ?

dbejarano820 commented 1 year ago

I'd love to look into this one if it's still on the sidelines @LucasLvy @DaVinciDz

makluganteng commented 1 year ago

Is this assigned yet ? if not im interested

AbdelStark commented 1 year ago

Is this assigned yet ? if not im interested

Please do. Assigned to you

makluganteng commented 1 year ago

i saw someone already created a pull request on this PR so ill unassigned myself and look for other issue.