keep-starknet-strange / madara

DEPRECATED in favor of https://github.com/madara-alliance/madara
MIT License
532 stars 301 forks source link

feat: compute state root in client instead of runtime #900

Closed AbdelStark closed 1 month ago

AbdelStark commented 1 year ago

Compute Global State Root in Client Instead of Runtime

Description

The goal of this issue is to move the computation of the global state root from the runtime to the client. This computation is a heavy process that consumes a lot of time and resources in the block production. By moving it to an asynchronous task, we can speed up block production.

Background

Currently, the global state root is computed as defined in the Starknet specs and fed into the block. A potential solution to speed up this process would be to include the state root of block N - 1 in the block header N, instead of the state root of the block N. However, for this to save time, it would need to be done in an asynchronous manner.

Tasks

  1. Research: Understand the current process of computing the global state root and how it can be moved to the client.
  2. Design: Create a design document detailing how the global state root computation will be moved to the client and made asynchronous. This should include any necessary changes to the existing architecture.
  3. Implementation: Implement the design, ensuring that the new process for computing the global state root is fully functional and improves block production speed.
  4. Testing: Write comprehensive tests to ensure the new process for computing the global state root works as expected and does not introduce any regressions.
  5. Documentation: Update the project documentation to reflect the new process for computing the global state root.

Acceptance Criteria

Resources

github-actions[bot] commented 1 year ago

There hasn't been any activity on this issue recently, and in order to prioritize active issues, it will be marked as stale. Please make sure to update to the latest version and check if that solves the issue. Let us know if that works for you by leaving a πŸ‘ Because this issue is marked as stale, it will be closed and locked in 7 days if no further activity occurs. Thank you for your contributions!

tdelabro commented 7 months ago

@antiyro you are working on this aren't you?

github-actions[bot] commented 6 months ago

There hasn't been any activity on this issue recently, and in order to prioritize active issues, it will be marked as stale. Please make sure to update to the latest version and check if that solves the issue. Let us know if that works for you by leaving a πŸ‘ Because this issue is marked as stale, it will be closed and locked in 7 days if no further activity occurs. Thank you for your contributions!

tdelabro commented 6 months ago

@antiyro you are working on this aren't you?

he is

github-actions[bot] commented 5 months ago

There hasn't been any activity on this issue recently, and in order to prioritize active issues, it will be marked as stale. Please make sure to update to the latest version and check if that solves the issue. Let us know if that works for you by leaving a πŸ‘ Because this issue is marked as stale, it will be closed and locked in 7 days if no further activity occurs. Thank you for your contributions!

tdelabro commented 4 months ago

@antiyro when integration in madara?

github-actions[bot] commented 3 months ago

There hasn't been any activity on this issue recently, and in order to prioritize active issues, it will be marked as stale. Please make sure to update to the latest version and check if that solves the issue. Let us know if that works for you by leaving a πŸ‘ Because this issue is marked as stale, it will be closed and locked in 7 days if no further activity occurs. Thank you for your contributions!

hhamud commented 3 months ago

@tdelabro @apoorvsadana if @antiyro or anyone else is not working on this one then I can grab this issue

tdelabro commented 3 months ago

@hhamud thanks but @antiyro is currently on it

github-actions[bot] commented 2 months ago

There hasn't been any activity on this issue recently, and in order to prioritize active issues, it will be marked as stale. Please make sure to update to the latest version and check if that solves the issue. Let us know if that works for you by leaving a πŸ‘ Because this issue is marked as stale, it will be closed and locked in 7 days if no further activity occurs. Thank you for your contributions!

tdelabro commented 1 month ago

repository archived in favor of https://github.com/madara-alliance/madara