[bug] add from_address in func compute_message_hash_sn_to_appc

[suiwater]

fn compute_message_hash_sn_to_appc( nonce: felt252, to_address: ContractAddress, selector: felt252, payload: Span ) -> felt252 should be: fn compute_message_hash_sn_to_appc(from_address: ContractAddress, nonce: felt252, to_address: ContractAddress, selector: felt252, payload: Span ) -> felt252 https://github.com/keep-starknet-strange/piltover/blob/2be9d46f00c9c71e2217ab74341f77b09f034c81/src/messaging/hash.cairo#L22 https://github.com/keep-starknet-strange/piltover/blob/2be9d46f00c9c71e2217ab74341f77b09f034c81/src/messaging/hash.cairo#L8 https://github.com/starkware-libs/cairo-lang/blob/caba294d82eeeccc3d86a158adb8ba209bf2d8fc/src/starkware/starknet/solidity/StarknetMessaging.sol#L88 https://github.com/starkware-libs/cairo-lang/blob/caba294d82eeeccc3d86a158adb8ba209bf2d8fc/src/starkware/starknet/solidity/StarknetMessaging.sol#L97 uint256(msg.sender), If this is an error, I will modify this bug.

[suiwater]

@glihm

[glihm]

Hey @suiwater sorry for the too huge delay here.

That's a very good catch. Let's add the new param. If you're still around, happy to assign if you can tackle it.

[onlydustapp[bot]]

Hey @glihm! Thanks for showing interest. We've created an application for you to contribute to Blobstream-Starknet. Go check it out on OnlyDust!

[suiwater]

@glihm Accidentally clicking on assignment. sorry.