keep-starknet-strange / raito

Bitcoin ZK client written in Cairo.
https://raito.wtf
MIT License
49 stars 37 forks source link

[feat] Validate coinbase input script (BIP-34) #109

Closed m-kus closed 2 months ago

m-kus commented 3 months ago

Check its size bounds and ensure it starts with the current block height.

Read more:

od-hunter commented 3 months ago

Can I work on this please @m-kus , please I’d love to be given the opportunity to contribute here.

onlydustapp[bot] commented 3 months ago

Hey @od-hunter! Thanks for showing interest. We've created an application for you to contribute to Raito - Bitcoin ZK Client. Go check it out on OnlyDust!

ShantelPeters commented 3 months ago

Can I please be assigned to this issue?

onlydustapp[bot] commented 3 months ago

Hey @ShantelPeters! Thanks for showing interest. We've created an application for you to contribute to Raito - Bitcoin ZK Client. Go check it out on OnlyDust!

od-hunter commented 3 months ago

Thank you ser!

m-kus commented 3 months ago

How is the progress @od-hunter ? Do you need help with this task?

maciejka commented 3 months ago

@od-hunter what is the status of the issue? We would like to complete all open Milestone 2 issues this week. Do need need any help?

od-hunter commented 3 months ago

Sorry sir @maciejka , I’m on it already. I’ll push a pr soon please

od-hunter commented 3 months ago

@maciejka @m-kus How do I check for the amount of bytes the script sig contains since the script sig is a type ByteArray

m-kus commented 3 months ago

ByteArray has len() method

m-kus commented 2 months ago

Resolved by #135