Implement compute_merkle_root Function

[AbdelStark]

Create a function to compute the Merkle root of a list of transaction hashes.

Acceptance Criteria:

• Implement compute_merkle_root(leaves: Span<u256>) -> Result<u256, Error>
• Handle the case of an empty list of hashes
• Implement the Merkle tree algorithm
• Duplicate the last hash if there's an odd number of hashes
• Implement the CVE-2012-2459 fix (check for duplicate hashes)
• Return the computed Merkle root
• unit tests

• Resources:

• ZeroSync Cairo 0 code: merkle_tree.cairo

[mubarak23]

@AbdelStark kindly assign this issue to me

[maciejka]

Hi @mubarak23, thanks for your interest. Please give us some time to organize issues.

[mubarak23]

@maciejka can you point to the zeroSync version of this function

[maciejka]

@maciejka can you point to the zeroSync version of this function

It is a matter of simple search in ZeroSync repo: https://github.com/ZeroSync/ZeroSync/blob/f1bd4736b0bac190ac48cbc8d5fcd92e2e1be7b9/src/block/merkle_tree.cairo#L16

[maciejka]

Hi @mubarak23, how is it going? Any progress on merkle_root computation?

[mubarak23]

Hi @mubarak23, how is it going? Any progress on merkle_root computation?

yes, am currently trying to find an alternative on cairo 1 for

copy_hash

and continue

[maciejka]

Maybe ask on the project tg group?

wt., 6 sie 2024, 13:42 użytkownik Mubarak Muhammad Aminu < @.***> napisał:

Hi @mubarak23 https://github.com/mubarak23, how is it going? Any progress on merkle_root computation?

yes, am currently trying to find an alternative on cairo 1 for

copy_hash

and continue

— Reply to this email directly, view it on GitHub https://github.com/keep-starknet-strange/raito/issues/12#issuecomment-2271088624, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABOTBYJWUYFDJ2BZCQTMKLZQCZDLAVCNFSM6AAAAABLYMMAIKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENZRGA4DQNRSGQ . You are receiving this because you were mentioned.Message ID: @.***>

[maciejka]

@mubarak23 please have a look: https://github.com/keep-starknet-strange/raito/pull/42. I drafted merkle_root computation. Are you able to test it?

[mubarak23]

@mubarak23 please have a look: #42. I drafted merkle_root computation. Are you able to test it?

i will write the test