add target_to_bits - Githubissues

keep-starknet-strange / raito

Bitcoin ZK client written in Cairo.

https://raito.wtf

MIT License

40 stars 34 forks source link

add target_to_bits #16

Closed harsh-ps-2003 closed 2 months ago

harsh-ps-2003 commented 3 months ago

[x] issue #10
[x] follows contribution guide
[x] code change includes tests

vercel[bot] commented 3 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
raito	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Aug 7, 2024 3:26pm

maciejka commented 3 months ago

Welcome and thanks for contribution. Please add unit tests. And add comment to the issue #10 so I can assign you.

maciejka commented 2 months ago

Please fix conflicts. You can put your functions into validation.cairo for now.

harsh-ps-2003 commented 2 months ago

So I should put the target_to_bits and vice versa (with the helper functions) in validation.cairo for now. Basically dump all the changes into a single file? Or maybe keep a separate utils.cairo file? @maciejka

maciejka commented 2 months ago

So I should put the target_to_bits and vice versa (with the helper functions) in validation.cairo for now. Basically dump all the changes into a single file? Or maybe keep a separate utils.cairo file? @maciejka

keep utils separate

maciejka commented 2 months ago

Fix fmt and tests, please.