[feat] Prevent double spending: UTXOs created and spent in the same block

keep-starknet-strange / raito

Bitcoin ZK client written in Cairo.

https://raito.wtf

MIT License

40 stars 34 forks source link

[feat] Prevent double spending: UTXOs created and spent in the same block #173

Closed TAdev0 closed 1 month ago

TAdev0 commented 1 month ago

[x] issue #164
[x] follows contribution guide
[ ] code change includes tests

vercel[bot] commented 1 month ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
raito	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Sep 15, 2024 5:23pm

TAdev0 commented 1 month ago

I curiously have the 2 first integration tests failing with

        tests/data/full_169.json — Panicked with 'Negative fee (output 5000000000 > input 0)'
        tests/data/full_757738.json — Panicked with 'Negative fee (output 625107042 > input 0)'

all other are passing. Trying to understand as my code isnt supposd to impact fee

update: found out the bug, was using let mut i = 0 while there was already a loop over a i variable defined in the outter scope. Using j instead solved the issue

TAdev0 commented 1 month ago

@maciejka @m-kus ready for final review!