search

keep-starknet-strange / raito

Bitcoin ZK client written in Cairo.
https://raito.wtf
MIT License
40 stars 34 forks source link

[feat] Do not do segwit related computations before the actual upgrade #180

Closed m-kus closed 1 month ago

m-kus commented 1 month ago

We do not have to do the following things before SEGWIT_BLOCK = 481_824:

Update compute_and_validate_tx_data function to reflect that.

Hint: return Default::default() for the wtxid merkle root for such cases.

Reading: https://learnmeabitcoin.com/technical/transaction/wtxid/

PavitraAgarwal21 commented 1 month ago

@m-kus Can you assigned it to me

onlydustapp[bot] commented 1 month ago

Hey @PavitraAgarwal21! Thanks for showing interest. We've created an application for you to contribute to Raito - Bitcoin ZK Client. Go check it out on OnlyDust!

PavitraAgarwal21 commented 1 month ago

without any changes , during the scarb test show this error test e2e:tests/data/full_169.json .../Users/pavitra/learning/raito/./scripts/data/integration_tests.sh: line 32: python: command not found

maciejka commented 1 month ago

without any changes , during the scarb test show this error test e2e:tests/data/full_169.json .../Users/pavitra/learning/raito/./scripts/data/integration_tests.sh: line 32: python: command not found

You need to install python? Then: https://github.com/keep-starknet-strange/raito?tab=readme-ov-file#build-dependencies