Closed TropicalDog17 closed 1 month ago
The latest updates on your projects. Learn more about Vercel for Git ↗︎
Name | Status | Preview | Comments | Updated (UTC) |
---|---|---|---|---|
raito | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Sep 25, 2024 2:36pm |
How is it going @TropicalDog17? It seems like this one is close to be finished.
How is it going @TropicalDog17? It seems like this one is close to be finished.
Yeah @maciejka I think these feature-based constants cannot be imported from an external package, I tried some workaround but it's no luck, maybe the language hasn't supported that feature yet. It appears that for the logging feature to work correctly, the constant file needs to be placed within the specific package where we want to enable logging.
Please check: https://github.com/keep-starknet-strange/raito/pull/224. I had to try it myself. Indeed there is a problem with conditional compilation in a multipackage project. Waiting for scarb developers response.
Please check: #224. I had to try it myself. Indeed there is a problem with conditional compilation in a multipackage project. Waiting for scarb developers response.
Please check: #224. I had to try it myself. Indeed there is a problem with conditional compilation in a multipackage project. Waiting for scarb developers response.
Which means we might need to wait until they implement it.
Please check: #224. I had to try it myself. Indeed there is a problem with conditional compilation in a multipackage project. Waiting for scarb developers response.
Which means we might need to wait until they implement it.
yeah I see, and very weird that the language server still recognize that feature.
yeah I see, and very weird that the language server still recognize that feature.
true
I am closing it for now. We will need to revisit this issue once feature support in Scarb is more mature. The work with my small fixes is parked in branch: feat/logging-macro
@TropicalDog17 please contact me on tg: @aundumla
Guide to be added in README.md of the logging package
Prequiste for using
log!
macro for a package:import this as a dependency in Scarb.toml
add the features in
Scarb.toml
add the
logging.cairo
(must be this name) file to the package root, like thepackage/consensus