dev: Remove block_hash from outpoint

keep-starknet-strange / raito

Bitcoin ZK client written in Cairo.

https://raito.wtf

MIT License

40 stars 34 forks source link

dev: Remove block_hash from outpoint #246

Closed lomasson closed 3 weeks ago

lomasson commented 4 weeks ago

[x] resolves #232
[x] follows contribution guide
[x] code change includes tests

vercel[bot] commented 4 weeks ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
raito	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Oct 11, 2024 4:31pm

m-kus commented 4 weeks ago

@lomasson pls also remove block_hash from the header (and revert block hash validation to the state at https://github.com/keep-starknet-strange/raito/blob/851e34779645bf4996a79ac6630c3770b4f70b93/packages/consensus/src/validation/work.cairo#L6)

maciejka commented 3 weeks ago

validate_proof_of_work

@m-kus please remind me why do we keep hash in the Header in the first place? Seems superfluous.

lomasson commented 3 weeks ago

@m-kus Can you check if I've make what you want me to do, I'm not sure because a test doesn't pass, and I'm not very sure if i take the right way to resolve that.

m-kus commented 3 weeks ago

@m-kus please remind me why do we keep hash in the Header in the first place? Seems superfluous.

It was used for Utreexo leaf hashing (not anymore)

m-kus commented 3 weeks ago

@m-kus Can you check if I've make what you want me to do, I'm not sure because a test doesn't pass, and I'm not very sure if i take the right way to resolve that.

@lomasson I see that CI is green, which test are you talking about? The diff looks ok to me

lomasson commented 3 weeks ago

@m-kus i don't how ci has green but somes testes don't pass(verification of utreexo_169 and outpoint_poseidon_hash), i have fix them and now i think its good, wdyt ?