keep-starknet-strange / raito

Bitcoin ZK client written in Cairo.
https://raito.wtf
MIT License
46 stars 37 forks source link

fix: relative locktime bug #258

Closed bloomingpeach closed 1 month ago

bloomingpeach commented 1 month ago

Add support for running the integration scripts on MacOS. Fixes #255

(.venv) client % scarb test --forceall tests/data/full_757752.json

     Running test client (scarb build && ../../scripts/data/integration_tests.sh)
    Finished `dev` profile target(s) in 9 seconds
running integration tests ...
test tests/data/full_757752.json ... ok (gas usage est.: 13975561509)
vercel[bot] commented 1 month ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
raito ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 11, 2024 0:01am
m-kus commented 1 month ago

@bloomingpeach can you please add the full_757752 test file from https://github.com/keep-starknet-strange/raito/pull/195/files ?

bloomingpeach commented 1 month ago

Hi @m-kus the full_757752 test is already available on the mk/script branch

m-kus commented 1 month ago

Hi @m-kus the full_757752 test is already available on the mk/script branch

I know, but we need it to test the fix in the CI pipeline for this PR

bloomingpeach commented 1 month ago

Sorry I don't quite get that @m-kus, what should I do. btw this PR I am merging to mk/script, not main branch. Please let me know should I change the base branch to main

m-kus commented 1 month ago

Ah ok, I didn't notice, sorry All good then, @maciejka pls take a look

maciejka commented 1 month ago

@bloomingpeach this pr has been closed by mistake. You changes were merged in: #262.