keep-starknet-strange / raito

Bitcoin ZK client written in Cairo.
https://raito.wtf
MIT License
40 stars 34 forks source link

[feat] Using `scarb get_block` to generate test blocks #52

Closed TAdev0 closed 2 months ago

TAdev0 commented 2 months ago

Includes:

Block 0 and Block of first p2p tx to Hal Finney were already added, now we have 13 blocks.

@maciejka if you have any idea of other blocks I could add

I removed the // TODO: implement in the _blockfilter.jq file so that it doesnt appear in all the TxIn of Transactions contained in generated blocks.

vercel[bot] commented 2 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
raito ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 10, 2024 0:23am
TAdev0 commented 2 months ago

@maciejka I guess we should wait for a correct script before merging this, so that all blocks after segwit contain correct is_segwit flag + witness field (and pre segwit block should also generate a witness field, but empty, to match our Transaction struct

maciejka commented 2 months ago

@maciejka I guess we should wait for a correct script before merging this, so that all blocks after segwit contain correct is_segwit flag + witness field (and pre segwit block should also generate a witness field, but empty, to match our Transaction struct

It is ok to merge work in progress. We will regenerate if necessary.

TAdev0 commented 2 months ago

@maciejka dont know for the compile for now, repo was not correctly structured regarding Tests modules (no lib.cairo file in it) hence was not detected when building.

If thats ok for you i'll close this PR, and open a new one.