feat(ScriptData): Python version + update sh/jq version

keep-starknet-strange / raito

Bitcoin ZK client written in Cairo.

https://raito.wtf

MIT License

40 stars 34 forks source link

feat(ScriptData): Python version + update sh/jq version #88

Closed lomasson closed 2 months ago

lomasson commented 2 months ago

[x] issue #28
[x] follows contribution guide
[ ] code change includes tests suite of #67(problem git)

vercel[bot] commented 2 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
raito	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Aug 21, 2024 9:57am

m-kus commented 2 months ago

@lomasson scarb run get_blocks fails to run, I suggest to keep it as is (we don't need to reimplement the same functionality twice) just swap get_block.sh with get_block.py in the get_blocks.sh.

When I try to swap get_block.sh with get_block.py the script works but it doesn't seem to create any test files. Please check on your end and also ensure that test files are generated correctly (and include new ones in the PR) + all tests pass

lomasson commented 2 months ago

@m-kus Is that what you want me to do? I didn't really understand (apart from the update on get_blocks) if you want me to generate some test files or generate or some tests for the test files in test.cairo (dynamically generated).

m-kus commented 2 months ago

@lomasson the expected result is that you can run scarb run get_blocks and all test blocks are regenerated (this is how it works right now) but this time with referenced outputs (outpoints). It is also expected that all current tests pass with the newly generated blocks (or necessary fixes should be applied).

lomasson commented 2 months ago

@m-kus I see, i'll update and send new pr