keep-starknet-strange / satoru

Synthetics platform for Starknet, inspired by GMX v2 design.

https://book.satoru.run/

MIT License

110 stars 74 forks source link

Feat: support dual interfaces for all external facing contracts #240

Open sparqet opened 10 months ago

sparqet commented 10 months ago

Description

External facing smart contracts should implement dual facing interfaces to allow better composability. It means that this contracts should support snake_case and CamelCase at the same time for external functions.

Example on open-zeppelin: https://github.com/OpenZeppelin/cairo-contracts/issues/596

dbejarano820 commented 10 months ago

I assume this one will be for later right

delaaxe commented 10 months ago

why is this needed for a brand new protocol on Cairo 2 though?

zarboq commented 10 months ago

It's to facilitate integration of products that already exists for GMX on EVM such as https://twitter.com/Puppetcopy.

But I don't think it's high priority yet. Let's build a working app first :rocket:

tarrencev commented 10 months ago

Imo it would be better to handle this on the sdk side. Applications like Puppetcopy would already need a starknet sdk. It can easily abstract this by converting camel case to snake case before constructing the txn