keep-starknet-strange / satoru

Synthetics platform for Starknet, inspired by GMX v2 design.
https://book.satoru.run/
MIT License
110 stars 73 forks source link

Implemented test for pricing utils. waiting for #417 to be completed #500

Open ametel01 opened 1 year ago

ametel01 commented 1 year ago

PR Type:

Current Behavior:

The function apply_exponent_factor() was missing, and no tests were available for apply_impact_factor(). Resolves: #494

Updated Behaviour:

Testing parameters mirror those found in GMX's test.

Breaking Change Introduced?

No

zarboq commented 12 months ago

Hey ! Thanks but @StarkFishinator already had an ongoing PR on this here and he was assigned on the issue so we'll leave him the priority for the 'apply_exponent_factor' part

ametel01 commented 12 months ago

I'll remove the changes in utils leaving only the tests, and draft this PR until utils are completed.