keep-starknet-strange / satoru

Synthetics platform for Starknet, inspired by GMX v2 design.
https://book.satoru.run/
MIT License
110 stars 73 forks source link

bug: Update order limit error #626

Open 0xted97 opened 6 months ago

0xted97 commented 6 months ago

Bug Report

Satoru version:

6ebc1a4

Current behavior: OrderNotUpdatable error when try update order limit

Expected behavior:

OrderNotUpdatable error when try update order market

Steps to reproduce:

const updateOrderCalldata: Call[] = [
        {
            contractAddress: contractAddresses.OrderHandler,
            entrypoint: "update_order",
            calldata: [
                key,
                size_delta_usd,
                acceptable_price,
                trigger_price,
                min_output_amount,
                order
            ]
        }
    ];
const account = new Account(provider, senderAddress, privateKey);
const tx = await account.execute(updateOrderCalldata);

Related code:

image

Other information:

ebukizy1 commented 6 months ago

assign me this wiil want to work on this