search

keep-starknet-strange / shinigami

Bitcoin Script VM in Cairo
https://shinigamibtc.dev
MIT License
57 stars 56 forks source link

[feat] Implement OP_VERIF & OP_NOTVERIF opcodes #112

Closed b-j-roberts closed 1 month ago

b-j-roberts commented 2 months ago

Implement the OP_VERIF & OP_NOTVERIF opcodes using opcodeReserved

This work will involve adding something like isOpcodeAlwaysIllegal from btcd to the Shinigami engine.

References

Note: This link isn't fully up to date on adding opcodes, but should be a good start: Guide on how to add an opcode in shinigami

EjembiEmmanuel commented 2 months ago

@b-j-roberts I'd like to work on this

onlydustapp[bot] commented 2 months ago

Hey @EjembiEmmanuel! Thanks for showing interest. We've created an application for you to contribute to shinigami. Go check it out on OnlyDust!

mexes20 commented 2 months ago

@b-j-roberts I'll like to work on this

onlydustapp[bot] commented 2 months ago

Hey @mexes20! Thanks for showing interest. We've created an application for you to contribute to shinigami. Go check it out on OnlyDust!

ShantelPeters commented 2 months ago

Hey @b-j-roberts can I jump on this ?

b-j-roberts commented 2 months ago

Hey @mexes20 , I'll assign you. Let me know if you have questions.

b-j-roberts commented 2 months ago

@mexes20 any updates on this issue?

adrianvrj commented 2 months ago

Hey @b-j-roberts if there is no response from the assigned dev, can I work on this?

b-j-roberts commented 2 months ago

Hey @b-j-roberts if there is no response from the assigned dev, can I work on this?

Yes, feel free to work on the issue if you're available.

mexes20 commented 2 months ago

@mexes20 any updates on this issue?

I'll send in a PR tomorrow, already working on it @b-j-roberts