keep-starknet-strange / shinigami

Bitcoin Script VM in Cairo
https://shinigamibtc.dev
MIT License
57 stars 56 forks source link

[bug] [bitcoin-core test] '0x4e03000000ffff 0x01 NOP' #133

Closed b-j-roberts closed 1 month ago

b-j-roberts commented 2 months ago

Issue

The following bitcoin-core test is failing to give the correct result :

0x4e03000000ffff 0x01 NOP

We expect this test to fail with an error, but it is running fine. More info from the test: PUSHDATA4 with not enough bytes

Replicate

To replicate the issue you can use the latest main branch with the following command:

scarb cairo-run '[[],64427082122961108293098671622834251366,16,[],3492594498579353424,8]'
EmmanuelAR commented 2 months ago

Heyyy can work on this ? @b-j-roberts i already work on art peace

EmmanuelAR commented 2 months ago

Heyyy can work on this ? @b-j-roberts i already work on art peace

b-j-roberts commented 2 months ago

@EmmanuelAR I'll keep this one open for now while you work on the other one.

EmmanuelAR commented 2 months ago

Got it @b-j-roberts

diegoTech14 commented 2 months ago

Hello! @b-j-roberts can I help with this issue?

martinvibes commented 2 months ago

hello @b-j-roberts i would love to help in solving this issue and to be a contrbutor to your repo

onlydustapp[bot] commented 2 months ago

Hey @martinvibes! Thanks for showing interest. We've created an application for you to contribute to shinigami. Go check it out on OnlyDust!

manlikeHB commented 2 months ago

@b-j-roberts can i work on this?

onlydustapp[bot] commented 2 months ago

Hey @manlikeHB! Thanks for showing interest. We've created an application for you to contribute to shinigami. Go check it out on OnlyDust!

onlydustapp[bot] commented 2 months ago

Hey @stevencartavia! Thanks for showing interest. We've created an application for you to contribute to shinigami. Go check it out on OnlyDust!

b-j-roberts commented 2 months ago

@diegoTech14 for sure, thank you for the help. Let me know if you have any issues.

diegoTech14 commented 2 months ago

Thank you sir, I'll start to work! @b-j-roberts