search

keep-starknet-strange / shinigami

Bitcoin Script VM in Cairo
https://shinigamibtc.dev
MIT License
57 stars 56 forks source link

[bug] [bitcoin-core test] '0 NOTIF 123' #134

Closed b-j-roberts closed 1 month ago

b-j-roberts commented 2 months ago

Issue

The following bitcoin-core test is failing to give the correct result :

0 NOTIF 123

We expect this to fail with an UNBALANCED_CONDITIONAL error do to missing ending.

Replicate

To replicate the issue you can use the latest main branch with the following command:

scarb cairo-run '[[],13546319592573254,7,[],3224115,3]'
addegbenga commented 2 months ago

Can I work on this

On Wed, 14 Aug 2024 at 1:08 AM, Brandon R @.***> wrote:

Issue

The following bitcoin-core test is failing to give the correct result :

0 NOTIF 123

We expect this to fail with an UNBALANCED_CONDITIONAL error do to missing ending. Replicate

To replicate the issue you can use the latest main branch with the following command:

scarb cairo-run '[[],13546319592573254,7,[],3224115,3]'

— Reply to this email directly, view it on GitHub https://github.com/keep-starknet-strange/shinigami/issues/134, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALLAOBXBBO2M6KYY4IAYD3LZRKNWLAVCNFSM6AAAAABMPIIPMSVHI2DSMVQWIX3LMV43ASLTON2WKOZSGQ3DINJTGU4TIOI . You are receiving this because you are subscribed to this thread.Message ID: @.***>

onlydustapp[bot] commented 2 months ago

Hey @addegbenga! Thanks for showing interest. We've created an application for you to contribute to shinigami. Go check it out on OnlyDust!

b-j-roberts commented 2 months ago

Hey @addegbenga , thanks! I'll assign you now.

b-j-roberts commented 1 month ago

This issue was solved in another PR which separated the scriptsig and pub key. https://github.com/keep-starknet-strange/shinigami/pull/152