search

keep-starknet-strange / shinigami

Bitcoin Script VM in Cairo
https://shinigamibtc.dev
MIT License
57 stars 56 forks source link

[bug] [bitcoin-core test] '1 OVER' #136

Closed b-j-roberts closed 1 month ago

b-j-roberts commented 2 months ago

Issue

The following bitcoin-core test is failing to give the correct result :

1 OVER

This code should be failing due to a INVALID_STACK_OPERATION.

More info from the test:

Replicate

To replicate the issue you can use the latest main branch with the following command:

scarb cairo-run '[[],49,1,[],1331053906,4]'
Gerson2102 commented 2 months ago

Maybe not a good first issue but I would like to try it!

b-j-roberts commented 2 months ago

@Gerson2102 No worries at all, let me know if you run into any questions or issues. Thank you!

bloomingpeach commented 1 month ago

Hi @b-j-roberts, can I work on this issue?

Gerson2102 commented 1 month ago

@b-j-roberts hey mate, i have not been working on this issue cause ive been working on other issues, sorry for the inconveniencies.

b-j-roberts commented 1 month ago

Okay, I will say @bloomingpeach you can work on this if you'd like then. Thanks for the update @Gerson2102

b-j-roberts commented 1 month ago

Seems this was a duplicate bug to another issue which was resolved by this PR, so I'll close this issue.