keep-starknet-strange / shinigami

Bitcoin Script VM in Cairo
https://shinigamibtc.dev
MIT License
57 stars 56 forks source link

[bug] [bitcoin-core test] 'NOP 2DUP 1' #138

Closed b-j-roberts closed 1 month ago

b-j-roberts commented 2 months ago

Issue

The following bitcoin-core test is failing to give the correct result :

NOP 2DUP 1

This code should be failing due to a INVALID_STACK_OPERATION.

Replicate

To replicate the issue you can use the latest main branch with the following command:

scarb cairo-run '[[],5132112,3,[],55269070479409,6]'
EmmanuelAR commented 2 months ago

Heyyyy @b-j-roberts fan I work o this ???? I already work with u !

b-j-roberts commented 2 months ago

Hey @EmmanuelAR , I'll keep this open while you work on the other issue for now. Thanks

coxmars commented 2 months ago

Hi @b-j-roberts this is not a good first issue but I would like to try it if you want 🫡

onlydustapp[bot] commented 2 months ago

Hey @coxmars! Thanks for showing interest. We've created an application for you to contribute to shinigami. Go check it out on OnlyDust!

manoahLinks commented 2 months ago

Hi @b-j-roberts i would love to work on this

onlydustapp[bot] commented 2 months ago

Hey @manoahLinks! Thanks for showing interest. We've created an application for you to contribute to shinigami. Go check it out on OnlyDust!

martinvibes commented 2 months ago

hello @b-j-roberts can i be assigned to this issue?

onlydustapp[bot] commented 2 months ago

Hey @martinvibes! Thanks for showing interest. We've created an application for you to contribute to shinigami. Go check it out on OnlyDust!

manlikeHB commented 2 months ago

@b-j-roberts, can i work on this?

onlydustapp[bot] commented 2 months ago

Hey @manlikeHB! Thanks for showing interest. We've created an application for you to contribute to shinigami. Go check it out on OnlyDust!

b-j-roberts commented 2 months ago

@coxmars I'll assign this one to you! Thank you, and let me know if you have questions.

b-j-roberts commented 1 month ago

This seems to have been a duplicate bug and has been resolved from this PR : https://github.com/keep-starknet-strange/shinigami/pull/155