Bug: [bitcoin-core test] '0x4c01 0x01 NOP'

keep-starknet-strange / shinigami

Bitcoin Script VM in Cairo

https://shinigamibtc.dev

MIT License

57 stars 56 forks source link

Closed b-j-roberts closed 1 month ago

b-j-roberts commented 2 months ago

The following bitcoin-core test is failing to give the correct result :

0x4c01 0x01 NOP

We expect this test to fail with an error, but it is running fine. More info from the test: PUSHDATA1 with not enough bytes

To replicate the issue you can use the latest main branch with the following command:

scarb cairo-run '[[],53292833124401,6,[],3492594498579353424,8]'

b-j-roberts commented 2 months ago

@manoahLinks thanks for showing interest in helping with these tests. Could you comment here and I can assign you?

manoahLinks commented 2 months ago

thanks brandon, i will be glad to work on this

onlydustapp[bot] commented 2 months ago

Hey @manoahLinks! Thanks for showing interest. We've created an application for you to contribute to shinigami. Go check it out on OnlyDust!

b-j-roberts commented 1 month ago

This bug was resolved as part of another PR so I will close it.