search

keep-starknet-strange / shinigami

Bitcoin Script VM in Cairo
https://shinigamibtc.dev
MIT License
60 stars 57 forks source link

[feat] Implement OP_LESSTHANOREQUAL opcode #15

Closed b-j-roberts closed 3 months ago

b-j-roberts commented 3 months ago

Implement the OP_LESSTHANOREQUAL opcode using the opcodeLessThanOrEqual reference implementation from btcd

References

Guide on how to add an opcode in shinigami

okhaimie-dev commented 3 months ago

@b-j-roberts I'll like to work on this next. Maybe, I'll wait on the other PR reviews first

onlydustapp[bot] commented 3 months ago

Hey @okhaimie-dev! Thanks for showing interest. We've created an application for you to contribute to shinigami. Go check it out on OnlyDust!

okhaimie-dev commented 3 months ago

@b-j-roberts I have addressed your suggestions in my other PRs https://github.com/keep-starknet-strange/shinigami/pull/12 https://github.com/keep-starknet-strange/shinigami/pull/29

Can I get started on this?

okhaimie-dev commented 3 months ago

completed this, but waiting on this PR to merge https://github.com/keep-starknet-strange/shinigami/pull/32

i need an implement of at least OP_2 & OP_3 to finish my test