keep-starknet-strange / shinigami

Bitcoin Script VM in Cairo
https://shinigamibtc.dev
MIT License
57 stars 56 forks source link

[feat] Implement OP_GREATERTHANOREQUAL opcode #16

Closed b-j-roberts closed 2 months ago

b-j-roberts commented 2 months ago

Implement the OP_GREATERTHANOREQUAL opcode using the opcode1Negate reference implementation from btcd

References

Guide on how to add an opcode in shinigami

nehkee commented 2 months ago

I would like to work on this . Can you assign it to me ? I'll work on it asap

onlydustapp[bot] commented 2 months ago

Hey @nehkee! Thanks for showing interest. We've created an application for you to contribute to shinigami. Go check it out on OnlyDust!

b-j-roberts commented 2 months ago

Definitely @nehkee , lmk if you have any questions or issues

okhaimie-dev commented 2 months ago

@nehkee let me know if you need help with this.

cc: @b-j-roberts i am happy to make a PR for this just in-case nehkee wants me to handle it. I already complete this implementation and tests on my localhost

b-j-roberts commented 2 months ago

@okhaimie-dev Feel free to create the PR, it seems @nehkee hasn't been able to start yet. I'll assign @nehkee a new issue when they become available!