search

keep-starknet-strange / shinigami

Bitcoin Script VM in Cairo
https://shinigamibtc.dev
MIT License
57 stars 56 forks source link

[bug] [bitcoin-core test] '0x4d 0x0100 0x08 8 EQUAL' #167

Closed b-j-roberts closed 1 month ago

b-j-roberts commented 1 month ago

Issue

The following bitcoin-core test is failing to give the correct result :

ScriptSig: '0x4d 0x0100 0x08' -- ScriptPubKey: '8 EQUAL'

This code should be passing, but is giving an invalid script error. This might have to do with little-endian encoding of the 0x0100 not being interpreted properly.

Replicate

To replicate the issue you can use the latest main branch with the following command:

scarb cairo-run '[[],64427082038777898854692793181038719032,16,[],15798080785170764,7]'
adrianvrj commented 1 month ago

hey, let me handle this one!

ooochoche commented 1 month ago

I am applying to this issue via OnlyDust platform.

My background and how it can be leveraged

I can handle this @b-j-roberts

onlydustapp[bot] commented 1 month ago

Hey @ooochoche! Thanks for showing interest. We've created an application for you to contribute to shinigami. Go check it out on OnlyDust!

Kaminar-i commented 1 month ago

please @b-j-roberts let me work on this

martinvibes commented 1 month ago

hey @b-j-roberts would love to take on this issue

onlydustapp[bot] commented 1 month ago

Hey @martinvibes! Thanks for showing interest. We've created an application for you to contribute to shinigami. Go check it out on OnlyDust!

b-j-roberts commented 1 month ago

Thanks for showing interest @adrianvrj , let me know if you have questions.

b-j-roberts commented 1 month ago

@adrianvrj any luck looking into this? Have you been able to identify where the bug is occuring?

adrianvrj commented 1 month ago

hi @b-j-roberts I did look into this but I haven't got into the solution, I will give a couple more tries and let you know if you should assign someone else