search

keep-starknet-strange / shinigami

Bitcoin Script VM in Cairo
https://shinigamibtc.dev
MIT License
57 stars 56 forks source link

[bug] [bitcoin-core test] "NOP 'bbbbb...'" #168

Closed b-j-roberts closed 1 month ago

b-j-roberts commented 1 month ago

Issue

The following bitcoin-core test is failing to give the correct result :

ScriptSig: 'NOP' -- ScriptPubKey: ''bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb''

This code should be passing, but is giving an error. This might have to do with little-endian encoding of the OP_PUSHDATAX input used when compiling the 'bbb...' string input.

Replicate

To replicate the issue you can use the latest main branch with the following command:

scarb cairo-run '[[],5132112,3,[69586059104193387537274732548867179037080081475771926260452121880712864354,173830035926118062982689285092699371470901631391433444789626887756977431138,173830035926118062982689285092699371470901631391433444789626887756977431138,173830035926118062982689285092699371470901631391433444789626887756977431138,173830035926118062982689285092699371470901631391433444789626887756977431138,173830035926118062982689285092699371470901631391433444789626887756977431138,173830035926118062982689285092699371470901631391433444789626887756977431138,173830035926118062982689285092699371470901631391433444789626887756977431138,173830035926118062982689285092699371470901631391433444789626887756977431138,173830035926118062982689285092699371470901631391433444789626887756977431138,173830035926118062982689285092699371470901631391433444789626887756977431138,173830035926118062982689285092699371470901631391433444789626887756977431138,173830035926118062982689285092699371470901631391433444789626887756977431138,173830035926118062982689285092699371470901631391433444789626887756977431138,173830035926118062982689285092699371470901631391433444789626887756977431138,173830035926118062982689285092699371470901631391433444789626887756977431138],158097496683802149148222529304529754400302073364794928047219239,26]'
Iwueseiter commented 1 month ago

Hi @b-j-roberts can I work on this?

onlydustapp[bot] commented 1 month ago

Hey @Iwueseiter! Thanks for showing interest. We've created an application for you to contribute to shinigami. Go check it out on OnlyDust!

martinvibes commented 1 month ago

hello @b-j-roberts can i please work on this

onlydustapp[bot] commented 1 month ago

Hey @martinvibes! Thanks for showing interest. We've created an application for you to contribute to shinigami. Go check it out on OnlyDust!

Kaminar-i commented 1 month ago

please branddon let me work on this

ooochoche commented 1 month ago

@b-j-roberts can I be assigned this 🙏🏻

onlydustapp[bot] commented 1 month ago

Hey @ooochoche! Thanks for showing interest. We've created an application for you to contribute to shinigami. Go check it out on OnlyDust!

PavitraAgarwal21 commented 1 month ago

hey can i work on this

onlydustapp[bot] commented 1 month ago

Hey @PavitraAgarwal21! Thanks for showing interest. We've created an application for you to contribute to shinigami. Go check it out on OnlyDust!

b-j-roberts commented 1 month ago

@Iwueseiter Any luck on this bug? Have you been able to identify where the error is occuring?

Iwueseiter commented 1 month ago

@Iwueseiter Any luck on this bug? Have you been able to identify where the error is occuring?

Yes. By tomorrow I should open a PR.

b-j-roberts commented 1 month ago

This script seems to have been fixed from a seperate bug issue, I'll close this for now