[bug] [bitcoin-core test] '-4294967295 0x05 0xFFFFFFFF80 EQUAL'

[b-j-roberts]

Issue

The following bitcoin-core test is failing to give the correct result :

ScriptSig: '-4294967295' -- ScriptPubKey: '0x05 0xFFFFFFFF80 EQUAL'

This code should be passing, but is failing at the EQUAL operation when comparing -4294967295 and 0xFFFFFFFF80.

Replicate

To replicate the issue you can use the latest main branch with the following command:

scarb cairo-run '[[],54648151398953683858372917,11,[],4642454408269420813098407607158452215490494213563695436,23]'

[b-j-roberts]

@petersdt would you be interested in taking this issue?

[NueloSE]

Can I work on this @b-j-roberts

[PavitraAgarwal21]

@b-j-roberts Can I take this issue

[onlydustapp[bot]]

Hey @PavitraAgarwal21! Thanks for showing interest. We've created an application for you to contribute to shinigami. Go check it out on OnlyDust!

[ooochoche]

Please @b-j-roberts can I be assigned this 🙏🏻

[onlydustapp[bot]]

Hey @NueloSE! Thanks for showing interest. We've created an application for you to contribute to shinigami. Go check it out on OnlyDust!

[petersdt]

@petersdt would you be interested in taking this issue?

yes pls @b-j-roberts

[b-j-roberts]

Awesome @petersdt , welcome to the project. Let me know if you have any questions!

[b-j-roberts]

Here are the links I sent in our discussion:

• Bitcoin Script opcodes
• Bitcoin Data opcodes, like 0x05
• Shinigami engine, add self.dstack.print() after here for debugging
• Shinigami data opcode used when running 0x05

[b-j-roberts]

Hey @petersdt , any update on debugging this test case?

[adrianvrj]

hi @b-j-roberts if the assigned person does not reports back I could tackle this one!

[petersdt]

Hey @petersdt , any update on debugging this test case?

Thanks to the resource you shared i have an understanding of how it works now. currently trying to log and locate the reason for failure.

I would revert on this soon. Am making some progress.

[b-j-roberts]

@petersdt Any updates on this? What are the 2 values in the stack on the equal operation?

[b-j-roberts]

This issue has been resolved from a bug fix in the ScriptNum wrap function. https://github.com/keep-starknet-strange/shinigami/commit/57c2fa4fa81ae68ad35ed4e6d31dffe37b3db7fa

Thank you.