keep-starknet-strange / shinigami

Bitcoin Script VM in Cairo
https://shinigamibtc.dev
MIT License
49 stars 54 forks source link

[feat] Script flags: Minimal data #175

Closed b-j-roberts closed 6 days ago

b-j-roberts commented 2 weeks ago

Bitcoin supports various script flags to enable/disable certain features. The ScriptVerifyMinimalData flag is used to require transactions have the minimal amount of data in push operation.

This issue will be to implement this flag into the Shinigami engine and create a set of test cases to verify the logic works as expected.

I recommend following the btcd implementation of ScriptVerifyMinimalData for reference, since our designs are so similar.

References

Shinigami scriptflags btcd ScriptVerifyMinimalData Shinigami engine

b-j-roberts commented 2 weeks ago

@ooochoche Would you be interested in taking this issue? Please comment here if so, thank you!

Gift-Naomi commented 2 weeks ago

@b-j-roberts Can i work on this?

onlydustapp[bot] commented 2 weeks ago

Hey @Gift-Naomi! Thanks for showing interest. We've created an application for you to contribute to shinigami. Go check it out on OnlyDust!

ooochoche commented 2 weeks ago

Yes I am interested @b-j-roberts thank you

onlydustapp[bot] commented 2 weeks ago

Hey @ooochoche! Thanks for showing interest. We've created an application for you to contribute to shinigami. Go check it out on OnlyDust!

b-j-roberts commented 2 weeks ago

@ooochoche Have you been able to work on this script flag?