search

keep-starknet-strange / shinigami

Bitcoin Script VM in Cairo
https://shinigamibtc.dev
MIT License
60 stars 56 forks source link

[feat] P2PKH transaction support #179

Closed b-j-roberts closed 1 month ago

b-j-roberts commented 2 months ago

Currently, all the opcodes for P2PKH are implemented. To ensure we support all P2PKH transactions/formats, we will need to create a set of tests for these transaction types and ensure all the logic and edge cases are handled properly. Also, using an example P2PKH transaction from mainnet as a test would be ideal.

References

learn P2PKH & examples example crypto tests

b-j-roberts commented 2 months ago

@prasincs Thank you for looking into this one!

prasincs commented 2 months ago

@b-j-roberts thanks, I'll take a stab at this

onlydustapp[bot] commented 2 months ago

Hey @prasincs! Thanks for showing interest. We've created an application for you to contribute to shinigami. Go check it out on OnlyDust!

ScottyDavies commented 2 months ago

Hi @b-j-roberts can work on this?