keep-starknet-strange / shinigami

Bitcoin Script VM in Cairo
https://shinigamibtc.dev
MIT License
64 stars 59 forks source link

[dev] [optimization] 'while i < n' to 'while x != n' #207

Closed b-j-roberts closed 2 months ago

b-j-roberts commented 2 months ago

To optimize shinigami, we should be using while x != n instead of while i < n when doing loops over a range. So for each instance in the code where a while i < n type loop is used, if possible, we should change them to use while x != n.

References

Example of location to optimize in the code

jsandinoDev commented 2 months ago

Hi @b-j-roberts can I work on this?

onlydustapp[bot] commented 2 months ago

Hey @jsandinoDev! Thanks for showing interest. We've created an application for you to contribute to shinigami. Go check it out on OnlyDust!

raizo07 commented 2 months ago

@b-j-roberts can I work on this?

onlydustapp[bot] commented 2 months ago

Hey @raizo07! Thanks for showing interest. We've created an application for you to contribute to shinigami. Go check it out on OnlyDust!

Jemiiah commented 2 months ago

@b-j-roberts I would love to work on this

onlydustapp[bot] commented 2 months ago

Hey @Jemiiah! Thanks for showing interest. We've created an application for you to contribute to shinigami. Go check it out on OnlyDust!

Mystic-Nayy commented 2 months ago

@b-j-roberts can I work on this?

onlydustapp[bot] commented 2 months ago

Hey @Gift-Naomi! Thanks for showing interest. We've created an application for you to contribute to shinigami. Go check it out on OnlyDust!

ShantelPeters commented 2 months ago

Hi @b-j-roberts can I take this up ?

onlydustapp[bot] commented 2 months ago

Hey @ShantelPeters! Thanks for showing interest. We've created an application for you to contribute to shinigami. Go check it out on OnlyDust!

b-j-roberts commented 2 months ago

Hi @b-j-roberts can I work on this?

Definitely, let me know if you have questions or issues. I'll assign now

b-j-roberts commented 2 months ago

@jsandinoDev Just assigned you 🚀