[feat] Implement P2SH tests / logic

[b-j-roberts]

Bitcoin has many different transaction types, one of the more popular being P2SH.

In order to support these, we will need to make sure all edge cases and some mainnet P2SH transactions can successfully be validated by Shinigami.

Since Shinigami's design is heavily inspired by btcd, I recommend looking through all pay-to-script hash logic there and replicating it inside Shinigami's engine. Also, the learnmeabitcoin link can be super helpful in understanding Bitcoin P2SH transactions in depth.

Then, using the learnmeabitcoin P2SH examples and existing Shinigami transaction tests, create a set of tests to ensure all P2SH transactions run properly.

Resources

• learnmeabitcoin P2SH
• Existing P2PK & P2PKH tests in Shinigami
• savedFirstStack btcd
• bip16 flag btcd

[b-j-roberts]

@varun-doshi Here is the issue, please comment here

[varun-doshi]

Yup, I can take this up

[b-j-roberts]

Hey @varun-doshi , any updates on this issue? Btw bip16 flags and support were added in this PR, but we will still need the test cases from learnmeabitcoin

[varun-doshi]

Hey @varun-doshi , any updates on this issue? Btw bip16 flags and support were added in this PR, but we will still need the test cases from learnmeabitcoin

In progress Should have an update soon

[b-j-roberts]

If we can get this last test passing, this issue will be complete ! Thanks for the efforts so far.

[varun-doshi]

I'll get on that