keep-starknet-strange / shinigami

Bitcoin Script VM in Cairo
https://shinigamibtc.dev
MIT License
64 stars 59 forks source link

[feat] Implement P2MS tests / features #248

Closed b-j-roberts closed 1 month ago

b-j-roberts commented 1 month ago

Bitcoin has many different transaction types, one of them being P2MS.

In order to support these, we will need to make sure all edge cases and some mainnet P2MS transactions can successfully be validated by Shinigami.

The learnmeabitcoin link can be super helpful in understanding Bitcoin P2MS transactions in depth.

Then, using the learnmeabitcoin P2MS examples and existing Shinigami transaction tests, create a set of tests to ensure all P2MS transactions run properly.

Resources

learnmeabitcoin P2MS Existing P2PK & P2PKH tests in Shinigami

mubarak23 commented 1 month ago

@b-j-roberts can I take this

mubarak23 commented 1 month ago

@b-j-roberts am still available to work on this

bloomingpeach commented 1 month ago

@b-j-roberts May I work on this?

manlikeHB commented 1 month ago

Hi @b-j-roberts, can i work on this?

supreme2580 commented 1 month ago

Hi @b-j-roberts can I be assigned to this?