search

keep-starknet-strange / shinigami

Bitcoin Script VM in Cairo
https://shinigamibtc.dev
MIT License
64 stars 59 forks source link

Parse Schnorr Pub Key & Implement TaprootSigVerifierImpl::new #267

Closed supreme2580 closed 1 month ago

supreme2580 commented 1 month ago
  1. parse_schnorr_pub_key : uses the reference from btcd https://github.com/btcsuite/btcd/blob/master/btcec/schnorr/pubkey.go#L23
  2. TaprootSigVerifierImpl::new: uses the reference from btcd https://github.com/btcsuite/btcd/blob/24eb815168f49dea84767817717a11bd7928eb23/txscript/sigvalidate.go#L313
vercel[bot] commented 1 month ago

@supreme2580 is attempting to deploy a commit to the keep-starknet-strange Team on Vercel.

A member of the Team first needs to authorize it.

Jeanmichel7 commented 1 month ago

It would be wise to make your PR against #225

or merge the PR feat:Taproot into main before? @b-j-roberts

supreme2580 commented 1 month ago

@Jeanmichel7 do you mean I should pull from feat:Taproot into my own branch?

Jeanmichel7 commented 1 month ago

@Jeanmichel7 do you mean I should pull from feat:Taproot into my own branch?

No, instead, make the pull request from your branch to the feat/taproot branch, since TaprootSigVerifier already has the structures.

supreme2580 commented 1 month ago

Ohhh I see... thanks