fix: more tests passing

SoarinSkySagar commented 1 week ago

[x] addresses issue #247
[x] follows contribution guide
[ ] ~code change includes tests~

New tests passing:

SIG_HIGH_S:

["0x48 0x304502203e4516da7253cf068effec6b95c41221c0cf3a8e6ccb8cbf1725b562e9afde2c022100ab1e3da73d67e32045a20e0b999e049978ea8d6ee5480d485fcf2ce0d03b2ef001","0x21 0x03363d90d447b00c9c99ceac05b6262ee053441c7e55552ffe526bad8f83ff4640 CHECKSIG","LOW_S","SIG_HIGH_S","P2PK with high S"]

DISCOURAGE_UPGRADABLE_WITNESS_PROGRAM:

[["304402205ae57ae0534c05ca9981c8a6cdf353b505eaacb7375f96681a2d1a4ba6f02f84022056248e68643b7d8ce7c7d128c9f1f348bcab8be15d094ad5cadd24251a28df8001","0479be667ef9dcbbac55a06295ce870b07029bfcdb2dce28d959f2815b16f81798483ada7726a3c4655da4fbfc0e1108a8fd17b448a68554199c47d08ffb10d4b8",0E-8],"","1 0x14 0x91b24bf9f5288532960ac687abb035127b1d28a5","DISCOURAGE_UPGRADABLE_WITNESS_PROGRAM,P2SH,WITNESS","DISCOURAGE_UPGRADABLE_WITNESS_PROGRAM","P2WPKH with future witness version"],

vercel[bot] commented 1 week ago

@SoarinSkySagar is attempting to deploy a commit to the keep-starknet-strange Team on Vercel.

A member of the Team first needs to authorize it.

SoarinSkySagar commented 1 week ago

gm @b-j-roberts, fixed 2 more tests, please review

SoarinSkySagar commented 1 week ago

@bloomingpeach made the required changes now

bloomingpeach commented 1 week ago

LGTM, thank you @SoarinSkySagar

SoarinSkySagar commented 1 week ago

LGTM, thank you @SoarinSkySagar

cool, now just waiting for @b-j-roberts to merge the PR

keep-starknet-strange / shinigami

fix: more tests passing #282

New tests passing: