[feat] `OP_[2..16]` and `OP_MIN` implementation

keep-starknet-strange / shinigami

Bitcoin Script VM in Cairo

https://shinigamibtc.dev

MIT License

57 stars 56 forks source link

[feat] `OP_[2..16]` and `OP_MIN` implementation #33

Closed ptisserand closed 2 months ago

ptisserand commented 2 months ago

[x] issue #5
[x] issue #17
[x] follows contribution guide
[x] code change includes tests

For testing purpose of OP_MIN opcode, I have added implementation & test for OP_2 to OP_16

To reduce code duplication in tests, I have wrote the following function fn test_op_n(value: u8) in test_opcodes.cairo

ptisserand commented 2 months ago

OP_2 to OP16 already merged in #32, but your tests are shorter. Ok I have fixed the conflict issue by merging main and I have kept my tests for OP{1..16} Let me know if I should remove them.