keep-starknet-strange / shinigami

Bitcoin Script VM in Cairo
https://shinigamibtc.dev
MIT License
57 stars 56 forks source link

[feat] Implement OP_ROT & OP_2ROT opcodes #70

Closed b-j-roberts closed 2 months ago

b-j-roberts commented 2 months ago

Implement the OP_ROT & OP_2ROT opcodess using the opcodeRot and opcode2Rot reference implementation from btcd

This will include implementing a version of RotN from btcd on the Shinigami stack object.

References

Guide on how to add an opcode in shinigami

okhaimie-dev commented 2 months ago

i am going to try this out

onlydustapp[bot] commented 2 months ago

Hey @okhaimie-dev! Thanks for showing interest. We've created an application for you to contribute to shinigami. Go check it out on OnlyDust!

b-j-roberts commented 2 months ago

Fast turn around! I like it! I'll take a look at your draft soon @okhaimie-dev 🔥

okhaimie-dev commented 2 months ago

@b-j-roberts it is not ready yet. But yes, feel free to take a look

okhaimie-dev commented 2 months ago

@b-j-roberts I will get back to this in two days = I should be able to have a passing test by then. I have been traveling since yesterday, and also prepping for an interview