search

keep-starknet-strange / snos

Rust Library for running the Starknet OS via the Cairo VM
MIT License
58 stars 28 forks source link

bug: snos fails if a block has no txs #408

Closed apoorvsadana closed 1 month ago

apoorvsadana commented 1 month ago

SNOS version:

3bd95bfb315a596519b5b1d3c81114fbfa06f8a6

Current behavior:

The SNOS calls starknet_getBlockWithTxs here. However, pathfinder throws an error if this method is called on a block with 0 txs.

Expected behavior:

SNOS should check if the block has no transactions (can be done by calling starknet_getBlockWithTxHashes)

Steps to reproduce:

We have a complicated setup where we

  1. Run Madara in devnet
  2. Connect pathfinder to Madara
  3. Run SNOS on pathfinder for empty blocks
apoorvsadana commented 1 month ago

Closed as this is ideally a Pathfinder issue https://github.com/eqlabs/pathfinder/issues/2311. However, in case Pathfinder refuses to solve this because Starknet blocks always has txs, maybe we can reopen it.