keep-starknet-strange / starknet-phone

Mobile OS built for Starknet
https://docs.starknetphone.xyz
MIT License
24 stars 29 forks source link

[bug] Back buttons throughout the wallet app do nothing #100

Closed trbutler4 closed 2 weeks ago

trbutler4 commented 1 month ago

How to reproduce:

Screenshot from 2024-10-20 22-40-58 navigate to either import account screen or create account screen and attempt to press the back button.

This should navigate back to the previous page using the NavController set up in WalletApp.kt

trbutler4 commented 1 month ago

open the wallet_app directory in android studio and search for TODO(#100) in the codebase to find all places where this needs to be updated.

raizo07 commented 1 month ago

@trbutler4 can I work on this?

sajalbnl commented 1 month ago

@trbutler4 i want to work on this

Mystic-Nayy commented 1 month ago

@trbutler4 Can I work on this?

trbutler4 commented 1 month ago

@sajalbnl @raizo07 @Mystic-Nayy this issue (and any tagged ODHack9) will be availble when ODHack starts on the 24th. Make sure you go through only dust and are ready to be active during the week of the hack if you want to do issues with this label

martinvibes commented 1 month ago

I am applying to this issue via OnlyDust platform.

My background and how it can be leveraged

hello @ i'm an experienced frontend developer and a blockchain developer i would love to work on this issue Pleasee kindly assign :)

Hoossayn commented 1 month ago

I am applying to this issue via OnlyDust platform.

My background and how it can be leveraged

I am a senior Android developer with 5+ years experience building scalable native android apps

How I plan on tackling this issue

ETA: 3 hours

aniruddhaaps commented 1 month ago

I am applying to this issue via OnlyDust platform.

My background and how it can be leveraged

I am a kotlin dev. A new-comer here, willing and ready to contribute to contribute to solve the issue.

Jethrolopwus commented 1 month ago

I am applying to this issue via OnlyDust platform.

My background and how it can be leveraged

A front end developer, proficient with javascript, react and next.js

How I plan on tackling this issue

I would create a button and set an navigation back to the previous page and set up navController.

trbutler4 commented 1 month ago

@raizo07 Hey! Please let me know if you have any questions about the issue, You can ask here or send a message in the telegram group here: https://t.me/+8G3EBNnfyS1lNzYx

raizo07 commented 3 weeks ago

@trbutler4 Finishing up, will send in a Pr today