[feat] Update hardcoded token price fetching to use currenly stored tokens

keep-starknet-strange / starknet-phone

Mobile OS built for Starknet

https://docs.starknetphone.xyz

MIT License

21 stars 23 forks source link

[feat] Update hardcoded token price fetching to use currenly stored tokens #106

Open trbutler4 opened 5 days ago

trbutler4 commented 5 days ago

Currently the balance fetching is just hardcoded to STRK and ETH . Update to get prices of all saved tokens.

Search TODO(#106) to find where this is done.

Requires #87

CollinsC1O commented 2 days ago

I am applying to this issue via OnlyDust platform.

My background and how it can be leveraged

Hello I'm a frontend and a blockchain developer. I will love to work on this issue. please assign

How I plan on tackling this issue

I will search for TODO(#106) in the codebase to find where STRK and ETH prices are hardcoded.
I will implement a function to dynamically fetch prices for all tokens stored in the wallet using a compatible price API.
I will replace the hardcoded price logic with the new function to ensure all saved tokens' prices are used.
I will write unit tests to verify that the price fetching works correctly for all tokens and handles cases where prices are unavailable.
I will ensure compliance with issue #87 as it’s a prerequisite for this task. Thanks

Samuel1-ona commented 2 days ago

I am applying to this issue via OnlyDust platform.

My background and how it can be leveraged Hello a blockchain developer. I will love to work on this issue

ShantelPeters commented 2 days ago

I am applying to this issue via OnlyDust platform.

My background and how it can be leveraged

My background in blockchain development and API integration equips me to efficiently handle this update while ensuring robust error handling and maintaining a smooth user experience.

How I plan on tackling this issue

To solve the issue of updating balance fetching to include all saved tokens instead of just hardcoded STRK and ETH, I would start by locating the TODO comment (#106) in the codebase. Next, I would modify the balance fetching function to dynamically retrieve the prices of all saved tokens. This could involve integrating a price feed API or using a decentralized price oracle to ensure accurate and up-to-date token prices. I would also ensure that the implementation aligns with the requirements outlined in issue #87.

jrmncos commented 2 days ago

I am applying to this issue via OnlyDust platform.

My background and how it can be leveraged

I'm a Software Enginer SR in web 2.0. Some tickets in this repo are not related exclusive with smart contracts, so my experience can work here. Also I have experience working on mobile. I will apply to various tickets in this repo, so sorry for the spam, I really like the project

How I plan on tackling this issue

I will do the required in the description.

aniruddhaaps commented 2 days ago

I am applying to this issue via OnlyDust platform.

My background and how it can be leveraged

I am a rust dev. A new-comer here, willing and ready to contribute to contribute to solve the issue.

sajalbnl commented 2 days ago

I am applying to this issue via OnlyDust platform. My background and how it can be leveraged I am an Android developer with 2 years of experience in Kotlin, Jetpack Compose, and MVVM architecture. I’ve contributed to StarkNet Phone, building wallet and light client apps by integrating APIs and implementing UI/UX features. I'm excited to contribute my skills to this project . ETA - 1 Day How I plan on tackling this issue i have worked on this issue earlier also and taking reference from previous work will start my work