keep-starknet-strange / starknet-phone

Mobile OS built for Starknet
https://docs.starknetphone.xyz
MIT License
24 stars 29 forks source link

[feat] Test execute #114

Closed trbutler4 closed 2 weeks ago

trbutler4 commented 1 month ago

Test execute() works as expected (solo and multi-calls should work as expected)

Might need to create a mock erc20 contract to test calls (see if the wallet is able to do a multi call (try sending eth to 2 accounts from the deployed wallet, both accounts' balance should update)

References

All the smart contracts are in the snphone_contracts directory, tests are run with snforge test

manlikeHB commented 1 month ago

I am applying to this issue via OnlyDust platform.

My background and how it can be leveraged

Hi, I am a skilled Cairo dev with lots of experience contributing to amazing projects, my profile is a witness to that statement.

How I plan on tackling this issue

I'll go through the repo to better understand the required functionality. I'll write a robust test to ensure all edge cases are covered and ensure the right balance are updated

ShantelPeters commented 1 month ago

I am applying to this issue via OnlyDust platform.

My background and how it can be leveraged

i am a frontend and blockchain developer .My experience in smart contract testing and blockchain development enables me to write robust tests for complex scenarios, ensuring that the multi-call functionality works as intended.

How I plan on tackling this issue

To approach the issue of testing execute() for solo and multi-calls, I would first create a mock ERC-20 contract to simulate the necessary transactions. Then, I would deploy a wallet smart contract and write test cases to check the functionality of solo and multi-calls. For multi-calls, I would execute a transaction sending ETH to two accounts simultaneously and ensure that both account balances update correctly.

martinvibes commented 1 month ago

I am applying to this issue via OnlyDust platform.

My background and how it can be leveraged

hello @ i'm an experienced frontend developer and a blockchain developer i would love to work on this issue Pleasee kindly assign :)

How I plan on tackling this issue

i would read the instructions careully and implement it and also make sure the tests are passing

please kindly assign :)

blessingbytes commented 1 month ago

I am applying to this issue via OnlyDust platform.

My background and how it can be leveraged

Hello I'm a frontend and blockchain developer. I will love to work on this issue

How I plan on tackling this issue

-I will create a mock ERC20 contract that I can use for testing purposes. This contract will include basic ERC20 functionalities, allowing me to simulate token transfers.

CollinsC1O commented 1 month ago

I am applying to this issue via OnlyDust platform.

My background and how it can be leveraged

Hello I'm a frontend and a blockchain developer and I will love to work on this

How I plan on tackling this issue

aniruddhaaps commented 1 month ago

I am applying to this issue via OnlyDust platform.

My background and how it can be leveraged

I am a rust dev. A new-comer here, willing and ready to contribute to contribute to solve the issue.

dimka90 commented 1 month ago

I am applying to this issue via OnlyDust platform.

My background and how it can be leveraged

I am a backend engineer with half a decade years of experience in creating and developing applications and smart contract that solves real life problems.

How I plan on tackling this issue

i will go through the projects and understand it , then write logic for the wallet to be

trbutler4 commented 1 month ago

@manlikeHB Hey! Please let me know if you have any questions about the issue, You can ask here or send a message in the telegram group here: https://t.me/+8G3EBNnfyS1lNzYx