keep-starknet-strange / tsubasa

Tsubasa onchain game built with Dojo, running on a Starknet Appchain.

https://play.tsubasa.win

MIT License

59 stars 30 forks source link

refactor #29

Closed rkdud007 closed 1 year ago

rkdud007 commented 1 year ago

28

about the test, right now i would suggest we make each unit test per each system, and later if contracts become too complicated, make tests.cairo or test folder for integration : reference : https://github.com/rkdud007/chess-dojo/blob/main/src/tests.cairo

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
tsubasa	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Aug 9, 2023 10:29am

rkdud007 commented 1 year ago

I dont think 'request for review' button is active :/ @LucasLvy could you review this ?

rkdud007 commented 1 year ago

@LucasLvy we need to have latest nightly version for CI, currently I have CI issue for print trait, which latest dojo solve it, and because of CI issue cannot merge it :) ( checked sozo test is working ) , suggest maybe we can merge without CI approval so this time and fix it other issue?