Closed remiroyc closed 1 year ago
The latest updates on your projects. Learn more about Vercel for Git ↗︎
Name | Status | Preview | Comments | Updated (UTC) |
---|---|---|---|---|
tsubasa | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Aug 19, 2023 10:57am |
cc @clicksave @LucasLvy
1 - Related to this question https://t.me/TsubasaStarknet/489 The card has a set size determined by the developer based on context (size param "xl", "lg", "md", "sm", "xs"), rather than being tied to the screen resolution. Sample: https://tsubasa-git-fork-remiroyc-feat-card-keep-starknet-strange.vercel.app/cards what do you think?
2 - Where do you plan to save player images? I don't know if you've generated the complete collection yet. In my view, this should be addressed in a separate issue. For the time being, I recommend creating cards without player images, similar to some of the cards in my link.
There is a problem in the star placement i think
cc @clicksave @LucasLvy
1 - Related to this question https://t.me/TsubasaStarknet/489 The card has a set size determined by the developer based on context (size param "xl", "lg", "md", "sm", "xs"), rather than being tied to the screen resolution. Sample: https://tsubasa-git-fork-remiroyc-feat-card-keep-starknet-strange.vercel.app/cards what do you think?
2 - Where do you plan to save player images? I don't know if you've generated the complete collection yet. In my view, this should be addressed in a separate issue. For the time being, I recommend creating cards without player images, similar to some of the cards in my link.
Nice! these are looking great. particularly on the larger versions of the cards. Awesome to see them in the different sizes. Feels good. Am noticing a few things that could be improved
Here's a link the the finalized illustrations
https://github.com/keep-starknet-strange/tsubasa/discussions/11#discussioncomment-6742425
There is a g
at the top of the frame, seems like it's not present on the main branch, can you remove that plz ?
cc @clicksave
Fix #5