search

keep-starknet-strange / tsubasa

Tsubasa onchain game built with Dojo, running on a Starknet Appchain.
https://play.tsubasa.win
MIT License
59 stars 30 forks source link

Place card on the field at the begining of the next player turn #60

Closed 0xLucqs closed 1 year ago

0xLucqs commented 1 year ago

Description

When a card is placed it goes on the side of the field and should stay there until the beginning of the player's next turn

Acceptance criteria

TeddyNotBear commented 1 year ago

I can take this one

Matth26 commented 1 year ago

Hey @TeddyNotBear ! I'm working on issue #24 (card buff when card is placed on its role). I want to trigger the code when card is placed on the field. Where do you plan to put the code related to beginning of the next player turn? A start_turn system?

TeddyNotBear commented 1 year ago

Hey @Matth26 You can check the PR here: https://github.com/keep-starknet-strange/tsubasa/pull/62 but to answer, as I noticed, there is no start_turn system and I don't think it's useful to create a system to start a turn. I've put the code in the end_turn system. You can have a look at the PR conversation if you want more details.

Matth26 commented 1 year ago

Sorry I missed your PR... Got it, indeed it does not make sense to make a start_turn system since no user action would trigger it (like the "End turn" button would trigger the end_turn system). Thanks

0xLucqs commented 1 year ago

Fixed by #62