search

keep-starknet-strange / zkramp

MIT License
20 stars 23 forks source link

[CONTRACTS] implement `add_liquidity` tests #83

Open 0xChqrles opened 1 hour ago

0xChqrles commented 1 hour ago

The tests are already defined in src/contracts/ramps/revolut/revolut_test.cairo. You just need to write their implementation following the way the escrow tests are implemented.

These contracts will be holding funds, so it's of utmost importance that the tests cover 100% of possible use cases, are readable, easily modifiable, and consistent.

To better understand how the contracts work, please read this article How to manage liquidity in a P2P ramping app

chachaleo commented 1 hour ago

Can I work on this ? :)

onlydustapp[bot] commented 1 hour ago

Hey @chachaleo! Thanks for showing interest. We've created an application for you to contribute to Zkramp. Go check it out on OnlyDust!

ShantelPeters commented 1 hour ago

@0xChqrles i will like to work on this

onlydustapp[bot] commented 1 hour ago

Hey @ShantelPeters! Thanks for showing interest. We've created an application for you to contribute to Zkramp. Go check it out on OnlyDust!

mubarak23 commented 1 hour ago

@0xChqrles am available to work on this

onlydustapp[bot] commented 1 hour ago

Hey @mubarak23! Thanks for showing interest. We've created an application for you to contribute to Zkramp. Go check it out on OnlyDust!