keep-starknet-strange / zkramp

MIT License
26 stars 25 forks source link

[CONTRACTS] implement `initiate_liquidity_retrival` tests #84

Closed 0xChqrles closed 1 month ago

0xChqrles commented 1 month ago

The tests are already defined in src/contracts/ramps/revolut/revolut_test.cairo. You just need to write their implementation following the way the escrow tests are implemented.

These contracts will be holding funds, so it's of utmost importance that the tests cover 100% of possible use cases, are readable, easily modifiable, and consistent.

To better understand how the contracts work, please read this article How to manage liquidity in a P2P ramping app

mubarak23 commented 1 month ago

@0xChqrles am available to work on this .

I am a Experience Cairo smart contract developer with experience working on projects such as Just Art Peace, Dojo, Kart, TBA, and Shinigami. Before transitioning to Cairo development, I was a backend developer specializing in Rust.

i also work and understand the codebase base on my previous experience working on issue #33 and #50 on this project

My recent work with cairo starknet

onlydustapp[bot] commented 1 month ago

Hey @mubarak23! Thanks for showing interest. We've created an application for you to contribute to Zkramp. Go check it out on OnlyDust!

Oshioke-Salaki commented 1 month ago

Please can I do this @0xChqrles

onlydustapp[bot] commented 1 month ago

Hey @Oshioke-Salaki! Thanks for showing interest. We've created an application for you to contribute to Zkramp. Go check it out on OnlyDust!

leohscl commented 1 month ago

Hey can I do this one ? @0xChqrles

onlydustapp[bot] commented 1 month ago

Hey @leohscl! Thanks for showing interest. We've created an application for you to contribute to Zkramp. Go check it out on OnlyDust!