search

keep-starknet-strange / zkramp

MIT License
26 stars 25 forks source link

[CONTRACTS] implement `retrieve_liquidity` tests #85

Closed 0xChqrles closed 4 weeks ago

0xChqrles commented 1 month ago

The tests are already defined in src/contracts/ramps/revolut/revolut_test.cairo. You just need to write their implementation following the way the escrow tests are implemented.

These contracts will be holding funds, so it's of utmost importance that the tests cover 100% of possible use cases, are readable, easily modifiable, and consistent.

To better understand how the contracts work, please read this article How to manage liquidity in a P2P ramping app

These tests are also related to #84

chachaleo commented 1 month ago

can I work on this ? :)

onlydustapp[bot] commented 1 month ago

Hey @chachaleo! Thanks for showing interest. We've created an application for you to contribute to Zkramp. Go check it out on OnlyDust!

Jemiiah commented 1 month ago

I would love for work on this @0xChqrles

Iwueseiter commented 1 month ago

Hi @0xChqrles can I tackle this task?

onlydustapp[bot] commented 1 month ago

Hey @Iwueseiter! Thanks for showing interest. We've created an application for you to contribute to Zkramp. Go check it out on OnlyDust!

ScottyDavies commented 1 month ago

Hi @0xChqrles can i please be assigned this task?

thesledge04 commented 1 month ago

hey @0xChqrles can i be assigned this task?

onlydustapp[bot] commented 1 month ago

Hey @ScottyDavies! Thanks for showing interest. We've created an application for you to contribute to Zkramp. Go check it out on OnlyDust!

onlydustapp[bot] commented 1 month ago

Hey @thesledge04! Thanks for showing interest. We've created an application for you to contribute to Zkramp. Go check it out on OnlyDust!

leohscl commented 1 month ago

I would like to get this one please