keep-starknet-strange / zkramp

MIT License
26 stars 25 forks source link

[CONTRACTS] implement `_get_available_liquidity` tests #90

Closed 0xChqrles closed 3 weeks ago

0xChqrles commented 1 month ago

The tests are already defined in src/contracts/ramps/revolut/revolut_test.cairo. You just need to write their implementation following the way the escrow tests are implemented.

These contracts will be holding funds, so it's of utmost importance that the tests cover 100% of possible use cases, are readable, easily modifiable, and consistent.

To better understand how the contracts work, please read this article How to manage liquidity in a P2P ramping app

These tests are also related to #89

mubarak23 commented 1 month ago

@0xChqrles am available to work on this.

I am a Cairo smart contract developer with experience working on projects such as Just Art Peace, Dojo, Kart, TBA, and Shinigami. Before transitioning to Cairo development, I was a backend developer specializing in Rust.

i also work and understand the codebase base on my previous experience working on issue #33 and #50 on this project

My recent work with cairo starknet

Jemiiah commented 1 month ago

i would love to work on this @0xChqrles

onlydustapp[bot] commented 1 month ago

Hey @mubarak23! Thanks for showing interest. We've created an application for you to contribute to Zkramp. Go check it out on OnlyDust!

onlydustapp[bot] commented 1 month ago

Hey @Jemiiah! Thanks for showing interest. We've created an application for you to contribute to Zkramp. Go check it out on OnlyDust!

Calebux commented 1 month ago

@0xChqrles I'll to work on this issue

onlydustapp[bot] commented 1 month ago

Hey @Calebux! Thanks for showing interest. We've created an application for you to contribute to Zkramp. Go check it out on OnlyDust!

od-hunter commented 1 month ago

Hi @0xChqrles , can I work on this please?

onlydustapp[bot] commented 1 month ago

Hey @od-hunter! Thanks for showing interest. We've created an application for you to contribute to Zkramp. Go check it out on OnlyDust!

Benjtalkshow commented 1 month ago

Hello @0xChqrles , Can I be assigned to this? I can tackle this issue asap.

onlydustapp[bot] commented 1 month ago

Hey @Benjtalkshow! Thanks for showing interest. We've created an application for you to contribute to Zkramp. Go check it out on OnlyDust!

Mystic-Nayy commented 1 month ago

@0xChqrles can I work on this?

Akshola00 commented 1 month ago

@0xChqrles Hi, Im available to work on this

leohscl commented 4 weeks ago

I'm up for this one @0xChqrles