keepassium / KeePassium

KeePass-compatible password manager for iOS
https://keepassium.com
Other
1.21k stars 103 forks source link

Safari on Macbook crashes on Autofill #216

Closed layandreas closed 2 years ago

layandreas commented 2 years ago

Description Safari crashes on using Quick AutoFill in Safari on MacOS only when app lock is disabled.

How to reproduce Steps to reproduce the behavior: Try logging in on any website using Safari and Quick Autofill with app lock disabled.

Expected behavior Successfull login without crash.

Environment:

Additional context Safari crash report: safari_crash_log.txt

Login example: image

Keepassium settings:

App lock disabled - no crashes when enabled.

image

image

2 databases are added in Keepassium, app lock disabled.

keepassium commented 2 years ago

Thanks, Andreas. Does this happen every time/on other websites?

I do get occasional Safari crashes with AutoFill on Big Sure, but they look like some Safari bug...

layandreas commented 2 years ago

Thanks, Andreas. Does this happen every time/on other websites?

I do get occasional Safari crashes with AutoFill on Big Sure, but they look like some Safari bug...

Every website and every time. Restarting the system did not help, seems directly related to disabled app lock.

keepassium commented 2 years ago

seems directly related to disabled app lock

Interesting... Thanks for emphasizing, I've overlooked this detail.

Cannot reproduce on 11.6.2, though. Will try later with Monterey.

keepassium commented 2 years ago

I have tested this on Intel macOS 12.2 + Safari 15.3, but could not reproduce. I suspect this might be something Touch ID related (which I don't have on the test machine).

Can you try 1.31.104? There was a Touch ID fix specifically for Quick AutoFill on macOS.

layandreas commented 2 years ago

I have tested this on Intel macOS 12.2 + Safari 15.3, but could not reproduce. I suspect this might be something Touch ID related (which I don't have on the test machine).

Can you try 1.31.104? There was a Touch ID fix specifically for Quick AutoFill on macOS.

1.31.104 appears to have solved the issues, no crash but Touch ID is prompted and password is filled in!

keepassium commented 2 years ago

1.31.104 appears to have solved the issues, no crash but Touch ID is prompted and password is filled in!

Great, thanks for checking!