keepassium / KeePassium

KeePass-compatible password manager for iOS
https://keepassium.com
Other
1.21k stars 103 forks source link

Revealing TOTP codes in folder view reveals every 16th TOTP code simultaneously #277

Closed timothymhuang closed 1 year ago

timothymhuang commented 1 year ago

Description Clicking the clock icon (to reveal the TOTP code) on an item in the list of your passwords reveals not just that TOTP code, but every 16th code.

How to reproduce Steps to reproduce the behavior:

  1. Open a database with at least 17 items in a single folder with TOTP added to each item, or at least every 16th item (e.g. 1,17,33,... or 5,21,37,...)
  2. Click the clock icon to reveal a TOTP code.
  3. Scroll down to see that other items have their TOTP code also revealed. You can also reveal multiple codes at once and they will both open every 16th code.
  4. Note that if the next 16th item does not have TOTP enabled (so most normal vaults since most sites don't support TOTP), then it will appear like the bug doesn't exist,

Expected behavior Only the TOTP code of the item I select reveals itself.

Screenshots Note: each item displays its own correct TOTP code, they just appear to be the same because I copied and pasted the same seed. Video Demonstration: https://youtu.be/h8LoeHxLOJk

Images: Revealing the TOTP code for 2 also reveals the code for 18 and 34 2FDA4333-A65B-45D9-BE0D-5011F210CE59L0001 png png DA5FEB0D-BEA6-49DC-B21A-AAACCC0C686EL0001 png png BF633059-E786-43B4-9D4A-64447D8DA7C2L0001 png png

Environment:

Additional context Add any other context about the problem here.

keepassium commented 1 year ago

Wow, this is one thorough bug report! Thank you, Timothy. I will get this fixed.